Which Zerg unit makes the most disgusting noises?

2:22 - Mortituri Te Salutant was also the first line from the "Brood War Aria" which we first hear in the Brood War cinematic intro that introduced both Stukov and DuGalle.

In Polish one of Stucov lines are "Teraz juz nawet Lugola mi nie pomoże". This translates to "Now even the Lugola wont help me". This is refrence to Lugol's iodine that was distibuted in Polish People Republic (Poland under Soviet control) after the Chernobyl catastrophe to protect people from radiation and because of lack of iodine tablets.

Also you forgot about Niadra voice lines. The queen that you control in one of HotS mission called "Enemy within"

The Kerrigan with the Echo-y voice is the one that, I think, is NOT available to the player. The infested Kerrigan that the player CAN control has some funny remarks if memory serves well.
Still, good job. Hoping to see the "Tauren Space Marine" in the Protoss one! (You know, due to the campaign and the "konami code input")

"Those about to die, I salute you" could also reference "For Those About To Rock (We Salute You)" by AC/DC, and given how many lines from Starcraft 1 referenced songs (especially Duran referencing Duran Duran), I can see it being a reference

I am surprised Niadra doesn't have any references. Although I do remember she had some jokes.

Ok that was short (Just like the SC1 Version) but still great.

I hope that you mention the Voiceline changes with the Protoss Units. The Phoenix for example has ''I have a lot of nerve... cords'' but they changed that line in the Legacy of the Void campaign where one major plot point is that every Protoss cuts their nerve cords and therefore loses their connection to the Khala. That results in that Phoenix line being changed to ''I used to have a lot of nerve.. uhm.. hm.. Cords''. Those changes are also present in Coop Mission i think. The High Templar is the one that got changed the most.

4:17 Kerrigan knows ball

I could have sworn thered be more, like the primal zerg Dahaka

Honestly I'm surprised you missed the iconic Starship Troopers quote by the hydralisks, that one's a classic! The infestor also has some very subtle references to the Flood from Halo, which feels appropriate, considering how hard the Halo franchise cribbed on StarCraft

from queen b*tch of the universe to primal. still no remorse...

What about Izsha?

For example, the line "My queen" references the fact that Kerrigan, the Queen of Blades, is her queen, and she won't let you forget it. Ever.

You forgot my favorite quote from the overlord!  "Gwurrurrrururrgh!"

"Grrrrraaaaaugh!" is also good, but it's a bit more obscure.

For those about to Rock, We solute YOU! - AC DC

So exited for the new quotes in the new starcraft.

Morituri te salutant was also a greeting for the emperor from gladiators before a fight in the arena

I love the changeling Zealot. Hilarious.

Please make the protoss one!

I love u AbelHawk.

Did you check the Xelnaga form to see if there were any lines hidden in  that unit?